Well I replaced my window runner parts and it was still knocking!
I found that the 2 10mm nuts that hold the window frame to the inside of the door were loose!
1 nut fell off it was that loose, so bit of lock tight and bolted back on no more knocking π